Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49059 )
Change subject: soc/intel/common/cse: Drop dependency on CHROMEOS for SOC_INTEL_CSE_LITE_SKU ......................................................................
Patch Set 2:
Patch Set 2: Code-Review+1
Patch Set 2:
we chatted a little on IRC, just leaving some comments here for posterity:
the CSE Lite SKU FW is more of an artifact of the shipped firmware, not necessarily the build itself, so once a board ships with CSE lite FW, that's what you're pretty much stuck with; IOW, yes this seems semantically correct to me, the CSE_LITE_SKU shouldn't be dependent on CHROMEOS, per se, from a build perspective
I think this is fine, but I'd like Furquan to chime in if possible to make sure I'm not missing something
That makes sense to me. As you captured, CSE Lite FW is an artifact of the shipped firmware. The dependency is more in terms of "Only Chrome OS boards use CSE Lite FW". But, that does not translate to "depends on CHROMEOS" for the build system. So, dropping the build time dependency seems correct.