Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37429 )
Change subject: bootblock: Provide some common prototypes
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37429/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37429/1//COMMIT_MSG@10
PS1, Line 10: southbridge is not specific to intel at all.
I think these are defined in intel/car.h because the code calling them is in intel/car.c? So I don't really see a point moving them to bootblock_common.h unless you move the whole bootblock_soc_init() from car.c somewhere else as well.
Northbridge/southbridge are still x86-specific, so if you want to use this on a non-Intel board, maybe move it into arch/x86 or cpu/x86?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37429
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I702cc6bad4afee4f61acf58b9155608b28eb417e
Gerrit-Change-Number: 37429
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 03 Dec 2019 20:02:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment