Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44154 )
Change subject: soc/amd/picasso/acpi: clean up global NVS
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44154/1/src/soc/amd/picasso/include...
File src/soc/amd/picasso/include/soc/nvs.h:
https://review.coreboot.org/c/coreboot/+/44154/1/src/soc/amd/picasso/include...
PS1, Line 29: aoac
Looks like we just set this and never read from it again. […]
might be worth looking into this later; not sure how much will change or be added in that area. only removed the obviously wrong or unused struct fields in this patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44154
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c6b580543089bf0180a7caeb9e6a47dc4ed4a1d
Gerrit-Change-Number: 44154
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Aug 2020 17:31:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment