Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39710 )
Change subject: soc/intel/tigerlake: unlock RTC memory
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/39710/1/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/39710/1/src/soc/intel/tigerlake/fsp...
PS1, Line 110: /* TODO: before UPD is avaialbe for RtcMemoryLock (offset:0x0621) */
'avaialbe' may be misspelled - perhaps 'available'?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39710
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63cec8a718285f424914e426d0399ed821588dfd
Gerrit-Change-Number: 39710
Gerrit-PatchSet: 4
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 02 Apr 2020 22:13:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment