Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47191 )
Change subject: mb/purism/librem_mini: Set unused GPIO pads to PAD_NC ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c:
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem... PS4, Line 412: /* GPD2 - NC */ : PAD_NC(GPD2, NONE),
but I do - R332 is not populated
Done
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem... PS4, Line 462: /* GPP_C6 - NC */ : PAD_NC(GPP_C6, NONE), : : /* GPP_C7 - NC */ : PAD_NC(GPP_C7, NONE),
look closer ;) R126 and R130 are not populated
aaand vendor had NC, too
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem... PS4, Line 562: : /* GPP_E15 - NC */ : PAD_NC(GPP_E15, NONE),
yup, because R324 is not populated; can you verify that on the board, please?
no markings on the board for resistors 😞
however, even vendor didn't have SCI configured, but GPO, while SMC_EXTSMI# would be an input. Setting GPO probably was done to prevent floating -> *should* be nc