Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil.
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45810/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45810/1/src/mainboard/google/zork/v...
PS1, Line 6: SPD_SOURCES += ddr4-spd-empty.bin # ID = 1(0b0001)
Looks like the tool changed. This change needs to be rebased on https://review.coreboot. […]
Gerrit isn't seeing this as a rebase on https://review.coreboot.org/c/coreboot/+/45818. Your git log should show 1c8d99bdd5a4c690d5db630e41630bd27c6df1ca as the parent commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28fc39f17e06ecd39f6567613e6ff5919becb2fd
Gerrit-Change-Number: 45810
Gerrit-PatchSet: 2
Gerrit-Owner: Lucas Chen
lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Lucas Chen
lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Vincent Wang
vwang@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Teresa Tseng
teresa_tseng@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 29 Sep 2020 13:19:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment