Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31416 )
Change subject: SMBIOS: Update BIOS Information (Type 0) to version V3.2.0 ......................................................................
Patch Set 2:
(4 comments)
Thanks for the update!
https://review.coreboot.org/#/c/31416/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31416/2//COMMIT_MSG@10 PS2, Line 10: Also fix some coding style This seems completely unrelated, please split out.
https://review.coreboot.org/#/c/31416/2/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31416/2/src/arch/x86/smbios.c@376 PS2, Line 376: if (rom_size - GiB >= 0) This would be easier to read as
if (rom_size >= GiB)
Also, the actual maximum number is 2^14-1, so this would be more accurate:
if (rom_size >= (1ull << 14) * MiB)
Then again, this makes it obvious that we don't need the `if` for a 32-bit number ;) (a smart compiler would warn that it's always false).
https://review.coreboot.org/#/c/31416/2/src/arch/x86/smbios.c@379 PS2, Line 379: rom_size / MiB The spec wants us to round up.
https://review.coreboot.org/#/c/31416/2/src/arch/x86/smbios.c@384 PS2, Line 384: */ Comment needs update. The spec *does* address it now :)