Attention is currently required from: Jérémy Compostella.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85554?usp=email )
Change subject: soc/intel/pantherlake: Add core scaling factors read support
......................................................................
Patch Set 11:
(1 comment)
File src/soc/intel/common/block/acpi/cpu_hybrid.c:
https://review.coreboot.org/c/coreboot/+/85554/comment/600a3f20_fc822b3f?usp... :
PS11, Line 18: enum cpu_perf_eff_type {
: CPU_TYPE_EFF,
: CPU_TYPE_PERF,
: };
this code change and https://review.coreboot.org/c/coreboot/+/85554/11/src/soc/intel/common/block... can be pushed as part of separate CL to avoid combining SoC and common code together into same patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85554?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a8e1e66a02e4bf6b1a41277e83c6dec786fe169
Gerrit-Change-Number: 85554
Gerrit-PatchSet: 11
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Wed, 08 Jan 2025 11:00:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No