Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33421 )
Change subject: util/superiotool/nuvoton.c: add NCT5539D register dump
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/#/c/33421/9/util/superiotool/nuvoton.c
File util/superiotool/nuvoton.c:
https://review.coreboot.org/#/c/33421/9/util/superiotool/nuvoton.c@637
PS9, Line 637: 0xa0
this seems to be a bit odd to me; i'd have expected 0x00 here. […]
from the superiotool output 0xa0 seems to be the correct value
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33421
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib55068035ca574b22d0fea81e1a291f7cf0329d3
Gerrit-Change-Number: 33421
Gerrit-PatchSet: 9
Gerrit-Owner: Pavel Sayekat
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Pavel Sayekat
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 12 Jun 2019 21:55:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment