30 Sep
2020
30 Sep
'20
5:53 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45635 )
Change subject: vendorcode/google: add SPD_PART_NUMBER_IN_CBI Kconfig option ......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45635/17/src/vendorcode/google/chro... File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/45635/17/src/vendorcode/google/chro... PS17, Line 107: y This should not be set to 'y' by default. We should let the mainboard select it only if required.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45635
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d393efd0fc731daa70d3990e5b69865be99b78b
Gerrit-Change-Number: 45635
Gerrit-PatchSet: 17
Gerrit-Owner: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Comment-Date: Wed, 30 Sep 2020 15:53:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment