Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37094 )
Change subject: Revert "3rdparts/fsp: Update fsp submodule" ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37094/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37094/2//COMMIT_MSG@11 PS2, Line 11: Reason for revert: Cannonlake FSP does not work anymore. FSP-M crashes/get stuck. IMHO, "does not work" is the most generic description of an issue. Currently, there is not enough information to reproduce this issue.
- Which mainboard does this happen with? With what coreboot code, specifically? - Which defconfig has been used that results in this boot failure? - Has anything else been tried before reverting?
On github IntelFSP/FSP, the difference between
59964173e18950debcc6b8856c5c928935ce0b4f
and
0bc2b07eab29a8a75cd084963c285ee5434e6666
is of 56 commits, which gets bisected in at most *six* tests. I am pretty sure that even less tests are required, because not every commit changes the Cannonlake FSP (did you mean CoffeeLake?).