Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45134 )
Change subject: lib: Add config MAINBOARD_OPTIONS for getting options from mainboard ......................................................................
Patch Set 12:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45134/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45134/7//COMMIT_MSG@12 PS7, Line 12: the log level will be set to CONFIG_DEFAULT_CONSOLE_LOGLEVEL.
In order to set log level before POST CAR, on Cooper Lake I can remove the check for CONSOLE_LEVEL_C […]
Add a config in CB:45684, so keep the current behavior the same.
https://review.coreboot.org/c/coreboot/+/45134/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45134/11//COMMIT_MSG@9 PS11, Line 9: Add config MAINBOARD_OPTIONS and remove CONSOLE_OVERRIDE_LOGLEVEL, : it lets mainboard provide overridden function for getting configuration : values via get_option(). Currently it's only used for overriding : console log level.
Add a description of how this works in the Documentation/ since it is a framework for going forward. […]
I was trying to add to the file describing get_option but could not find it, any suggestion where I should add this?
https://review.coreboot.org/c/coreboot/+/45134/11//COMMIT_MSG@17 PS11, Line 17: performance.
This is a nice cleanup and could be a separate commit.
Split to CB:45684
https://review.coreboot.org/c/coreboot/+/45134/11/src/console/init.c File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/45134/11/src/console/init.c@30 PS11, Line 30:
AIUI, `.bss` would be used for `console_loglevel` because the initialization […]
Add a config in CB:45684, so keep the current behavior the same.