View Change
4 comments:
Commit Message:
Patch Set #7, Line 12: the log level will be set to CONFIG_DEFAULT_CONSOLE_LOGLEVEL.
In order to set log level before POST CAR, on Cooper Lake I can remove the check for CONSOLE_LEVEL_C […]
Add a config in CB:45684, so keep the current behavior the same.
Commit Message:
Patch Set #11, Line 9:
Add config MAINBOARD_OPTIONS and remove CONSOLE_OVERRIDE_LOGLEVEL,
it lets mainboard provide overridden function for getting configuration
values via get_option(). Currently it's only used for overriding
console log level.
Add a description of how this works in the Documentation/ since it is a framework for going forward. […]
I was trying to add to the file describing get_option but could not find it, any suggestion where I should add this?
Patch Set #11, Line 17: performance.
This is a nice cleanup and could be a separate commit.
Split to CB:45684
File src/console/init.c:
To view, visit change 45134. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278e392bed178df7a8cdb90685963c1fedf0bcc4
Gerrit-Change-Number: 45134
Gerrit-PatchSet: 12
Gerrit-Owner: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Jingle Hsu <jingle_hsu@wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju@vdg.name>
Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang@wiwynn.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: insomniac <insomniac@slackware.it>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 24 Sep 2020 10:22:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones <marc@marcjonesconsulting.com>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Johnny Lin <Johnny_Lin@wiwynn.com>
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment