Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47594 )
Change subject: libpayload/keyboard: Reset to scancode set #2 on exit ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4: This change breaks all recent chromebooks that pass the keymap via ACPI from coreboot when they run libpayload keyboard init (which only happens in developer mode).
The default power up state of the 8042 module in the chrome EC (and according to docs I can find online, like https://wiki.osdev.org/%228042%22_PS/2_Controller#Translation) is set2+translate (i.e. set1) which is the format that the keymap is provided to the kernel in (https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...)
Since we don't always run the libpayload keyboard init because we don't always want keyboard input in firmware there isn't a way to consistently provide the keymap if it sometimes changes, so I don't think libpayload should be changing things from the default. Or at least it should probably be guarded by a Kconfig.