Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 )
Change subject: adding new mainboard ......................................................................
Patch Set 6:
(11 comments)
Many vendors are just reselling mainboards from other companies. Is this yours? https://www.gigabyte.com/de/Motherboard/GA-H61M-S1-rev-21#ov
If yes, then the vendor is Gigabyte.
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig File src/mainboard/ongy/Kconfig:
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig@... PS6, Line 12: default "H61M-S1" Ongy
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig.... File src/mainboard/ongy/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig.... PS6, Line 2: bool "ongy" _O_ngy
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/Kconfig:
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: ## : ## This file is part of the coreboot project. : ## : ## : ## This program is free software; you can redistribute it and/or modify : ## it under the terms of the GNU General Public License as published by : ## the Free Software Foundation; version 2 of the License. : ## : ## This program is distributed in the hope that it will be useful, : ## but WITHOUT ANY WARRANTY; without even the implied warranty of : ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : ## GNU General Public License for more details. : ## Replace by ..
## SPDX-License-Identifier: GPL-2.0-only ## This file is part of the coreboot project.
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 15: if BOARD_H61M_S1 BOARD_ONGY_H61M_S1
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: config BOARD_H61M_S1 BOARD_ONGY_H61M_S1
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 2: bool "h61m-s1" H61M-S1
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 2: /* This file is part of the coreboot project. */ Add a new line this here.
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: /* : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Replace by ..
/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: /* : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Replace by ..
/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 13: #define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0 Not sure if this is required here, but I would switch that define with that include two lines laters
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: /* : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Replace by ..
/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */