Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40245 )
Change subject: mainboard/volteer: Update Aux settings for Port 0 ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40245/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40245/5/src/mainboard/google/voltee... PS5, Line 128: 0x090E000A These values are hardcoded in an FSP header, but could we build it up from a macro so we don't need magic values in devicetree?
#define FSP_PAD(group, pad) 0x09000000 | (group) << 16 | (pad)
register "IomTypeCPortPadCfg[0]" = "FSP_PAD(GPP_E, GPP_E10-GPP_E0)" (or something similar)
This breaks down if the group numbers don't match, and something seems to be off between FSP and coreboot so we might need a new table:
coreboot: #define GPP_E 0xC
FSP: #define GPIO_VER4_LP_GROUP_GPP_E 0x090E
The GPP_E10-GPP_E0 isn't very readable either, but overall this is more informative than the magic value from a closed source header.