Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45088 )
Change subject: inteltool: Add support to print TME status
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45088/2/util/inteltool/cpu.c
File util/inteltool/cpu.c:
https://review.coreboot.org/c/coreboot/+/45088/2/util/inteltool/cpu.c@221
PS2, Line 221:
tab please
Done
https://review.coreboot.org/c/coreboot/+/45088/2/util/inteltool/cpu.c@232
PS2, Line 232: msr_t data;
: data = rdmsr_from_cpu(cpunum, IA32_TME_ACTIVATE);
good to create a helper function so is_tme_locked and is_tme_enabled could use the same ?
i would like to keep both functions separate to check if TME is enabled/locked. it would be more modular.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45088
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I584ac4b045ba80998d454283e02d3f28ef45692d
Gerrit-Change-Number: 45088
Gerrit-PatchSet: 3
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Sep 2020 18:59:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment