Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43631 )
Change subject: mb/system76/lemp9: update HDA pin config
......................................................................
Patch Set 9:
Patch Set 8:
Can you give a little more info where the old / new value came from?
The old value means "Disabled", the new value means something. There are macros to make HDA configs human-readable, but why would anyone bother using them? ðŸ˜
Look at this hda_verb.c! It's READABLE! 😮 https://review.coreboot.org/c/coreboot/+/39995/4/src/mainboard/siemens/chili...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43631
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215
Gerrit-Change-Number: 43631
Gerrit-PatchSet: 9
Gerrit-Owner: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
Gerrit-Comment-Date: Mon, 20 Jul 2020 22:42:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment