Attention is currently required from: Paul Menzel, Kenneth Chan.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63394 )
Change subject: mb/google/guybrush: allow MKBP devices and disable TBMC device
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63394/comment/f85ae95e_3ee25923
PS1, Line 9: Enable MKBP (Matrix Keyboard Protocol) interface for all guybrush family
: to use for buttons and switches.
Why is that better? What problem does it solve?
MKBP is needed to properly inhibit volume keys.
EC has already been switched to sending MKBP events, so some functionality is broken without this change.
Patchset:
PS1:
Please test `firmware_ECPowerButton` and verify it passes with this CL.
Confirmed passing on guybrush variant.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63394
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9980f2b5bf10b12f2bd666212b5bce925dc323d
Gerrit-Change-Number: 63394
Gerrit-PatchSet: 1
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Diana Zigterman
dzigterman@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 06 Apr 2022 14:57:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment