David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36328 )
Change subject: [RFC] Documentation/fsp: Discuss FSP-S issues ......................................................................
Patch Set 2: Code-Review-1
(2 comments)
Good content overall, but I strongly advise against legal speculation.
https://review.coreboot.org/c/coreboot/+/36328/2/Documentation/fsp/fsp-s_dis... File Documentation/fsp/fsp-s_discussion.md:
https://review.coreboot.org/c/coreboot/+/36328/2/Documentation/fsp/fsp-s_dis... PS2, Line 173: FSP Creates Legal Uncertainty Speculating about legal issues is a surefire way to prevent anybody from Intel from reading or commenting on this. I recommend removing the section, or updating the commit message to avoid misleading people about discussions or convincing Intel with this since that simply won't happen.
https://review.coreboot.org/c/coreboot/+/36328/2/Documentation/fsp/fsp-s_dis... PS2, Line 204: The few lines of code in FSP-S that help to get a : mainboard running, don't outweigh the damage it does. However, one : can't have the cherries without taking the whole menu, which takes : years to digest. Too much editorializing IMO