Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Nick Vaccaro.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61627 )
Change subject: drivers/pcie/generic: Add new pcie generic chip driver
......................................................................
Patch Set 3:
(2 comments)
File src/drivers/pcie/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/61627/comment/142e41b5_4def4da7
PS3, Line 20: !config
You also need to update this
https://review.coreboot.org/c/coreboot/+/61627/comment/dbf95ca2_b7e2191f
PS3, Line 41: pci_rom_ssdt(dev);
This is skipped when `!config->is_untrusted`, is it intentional?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61627
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53986614dcbf4d10a6bb4010e131f5ff5a9d25cf
Gerrit-Change-Number: 61627
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Sat, 05 Feb 2022 13:12:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment