[coreboot-gerrit] Change in coreboot[master]: [RFC]lib/coreboot_tables: Introduce BOOT_MEDIA_PARAMS2

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33107 )

Change subject: [RFC]lib/coreboot_tables: Introduce BOOT_MEDIA_PARAMS2
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33107/4/src/commonlib/include/commo... 
File src/commonlib/include/commonlib/coreboot_tables.h:

https://review.coreboot.org/c/coreboot/+/33107/4/src/commonlib/include/commo... 
PS4, Line 408: struct lb_boot_media_params {
Still not clear why you can't just extend existing structure (see earlier CL-level comments about this).

https://review.coreboot.org/c/coreboot/+/33107/4/src/commonlib/include/commo... 
PS4, Line 494: 	uint64_t mmap_mmio_address;
How does this relate to the FMAP-in-CBMEM thing you just uploaded? Most of this stuff is duplicated between the two structures. Do we need both? How about just creating a new separate struct for the MMAP stuff (that's only added for Apollolake-like devices) and getting the rest out of the FMAP copy?