2 comments:
File src/commonlib/include/commonlib/coreboot_tables.h:
Patch Set #4, Line 408: struct lb_boot_media_params {
Still not clear why you can't just extend existing structure (see earlier CL-level comments about this).
Patch Set #4, Line 494: uint64_t mmap_mmio_address;
How does this relate to the FMAP-in-CBMEM thing you just uploaded? Most of this stuff is duplicated between the two structures. Do we need both? How about just creating a new separate struct for the MMAP stuff (that's only added for Apollolake-like devices) and getting the rest out of the FMAP copy?
To view, visit change 33107. To unsubscribe, or for help writing mail filters, visit settings.