Attention is currently required from: Dolan Liu, Eric Lai, Karthik Ramasubramanian, Lawrence Chang.
Weimin Wu has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/83496?usp=email )
Change subject: mb/google/dedede/var/awasuki: Initialise overridetree
......................................................................
Patch Set 7:
(2 comments)
File src/mainboard/google/dedede/variants/awasuki/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83496/comment/168420b1_d2040751?usp... :
PS6, Line 21: #| I2C1 | Disable |
: #| I2C2 | Touchscreen |
: #| I2C3 | Disable
Also you need to do disable I2C in FSP config like below: […]
Done
https://review.coreboot.org/c/coreboot/+/83496/comment/656a34d2_a6154df7?usp... :
PS6, Line 204: device pci 1c.7 on
: chip drivers/wifi/generic
: register "wake" = "GPE0_DW2_03"
: device pci 00.0 on end
: end
Does this board also support external/discrete Wifi? You need this only when discrete Wifi is used.
Yes, need to support RTL8852BE PCIe Wifi module.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83496?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie8194b6eca3e88f08f92e0ac8a9063b8de738652
Gerrit-Change-Number: 83496
Gerrit-PatchSet: 7
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Lawrence Chang
lawrence.chang@intel.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Attention: Lawrence Chang
lawrence.chang@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Sun, 21 Jul 2024 09:46:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com