[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Clean up report_cpu_info() function

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36531 )

Change subject: soc/intel/icelake: Clean up report_cpu_info() function
......................................................................

soc/intel/icelake: Clean up report_cpu_info() function

This patch makes below clean up for report_cpu_info() function
1. Replace cpu_string with cpu_not_found
2. Assign default string "Platform info not available" to cpu_not_found string
3. Add array out of bound check while skiping leading white space in cpu brand
string name

Change-Id: I41c76eb93f0c5229c4a49aa041339b8ad51ad34a
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36531
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/icelake/bootblock/report_platform.c
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/intel/icelake/bootblock/report_platform.c b/src/soc/intel/icelake/bootblock/report_platform.c
index a9eef40..660aab9 100644
--- a/src/soc/intel/icelake/bootblock/report_platform.c
+++ b/src/soc/intel/icelake/bootblock/report_platform.c
@@ -93,7 +93,8 @@
 {
    struct cpuid_result cpuidr;
    u32 i, index, cpu_id, cpu_feature_flag;
-	char cpu_string[50], *cpu_name = cpu_string; /* 48 bytes are reported */
+	const char cpu_not_found[] = "Platform info not available";
+	const char *cpu_name = cpu_not_found; /* 48 bytes are reported */
    int vt, txt, aes;
    msr_t microcode_ver;
    static const char *const mode[] = {"NOT ", ""};
@@ -102,9 +103,7 @@

index = 0x80000000;
    cpuidr = cpuid(index);
-	if (cpuidr.eax < 0x80000004) {
-		strcpy(cpu_string, "Platform info not available");
-	} else {
+	if (cpuidr.eax >= 0x80000004) {
    	int j = 0;

for (i = 2; i <= 4; i++) {
@@ -116,10 +115,11 @@
    	}
    	p[12] = 0;
    	cpu_name = (char *)p;
+
+		/* Skip leading spaces in CPU name string */
+		while (cpu_name[0] == ' ' && strlen(cpu_name) > 0)
+			cpu_name++;
    }
-	/* Skip leading spaces in CPU name string */
-	while (cpu_name[0] == ' ')
-		cpu_name++;

microcode_ver.lo = 0;
    microcode_ver.hi = 0;