Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34782 )
Change subject: mb/google/hatch: Refactor override_early_gpio_table
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34782/4/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/hatch/gpio.c:
https://review.coreboot.org/c/coreboot/+/34782/4/src/mainboard/google/hatch/...
PS4, Line 56: PAD_CFG_GPI(GPP_F2, NONE, PLTRST),
Sure, gpio_base2_value() calls gpio_input() before reading the GPIOs, which, from gpio_base2_value() […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34782
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0552b08a284fd6fb41a09fef431a0d006b0cf0bd
Gerrit-Change-Number: 34782
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Aug 2019 15:23:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment