Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30826 )
Change subject: security/tpm/tss/tcg-2.0: Add TPM2 function tlcl_getcapability() ......................................................................
Patch Set 18:
(5 comments)
https://review.coreboot.org/c/coreboot/+/30826/15/src/security/tpm/tss/tcg-2... File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/30826/15/src/security/tpm/tss/tcg-2... PS15, Line 373: * Please note that the capabilityData is not unmarshalled.
My mistake during reviewing the code. […]
Done
https://review.coreboot.org/c/coreboot/+/30826/15/src/security/tpm/tss/tcg-2... PS15, Line 403: sizeof(TPMI_YES_NO) - sizeof(struct tpm_header));
The response data will be just copied.
Done
https://review.coreboot.org/c/coreboot/+/30826/16/src/security/tpm/tss/tcg-2... File src/security/tpm/tss/tcg-2.0/tss_structures.h:
https://review.coreboot.org/c/coreboot/+/30826/16/src/security/tpm/tss/tcg-2... PS16, Line 234: #define PCR_SELECT_MIN ALIGN_UP(PLATFORM_PCR, 8)/8
Macros with complex values should be enclosed in parentheses
Done
https://review.coreboot.org/c/coreboot/+/30826/16/src/security/tpm/tss/tcg-2... PS16, Line 235: #define PCR_SELECT_MAX ALIGN_UP(IMPLEMENTATION_PCR, 8)/8
Macros with complex values should be enclosed in parentheses
Done
https://review.coreboot.org/c/coreboot/+/30826/15/src/security/tpm/tss/tcg-2... File src/security/tpm/tss/tcg-2.0/tss_structures.h:
https://review.coreboot.org/c/coreboot/+/30826/15/src/security/tpm/tss/tcg-2... PS15, Line 235: #define PCR_SELECT_MAX ((IMPLEMENTATION_PCR + 7) / 8)
Please use ALIGN_UP() for these.
Done