[coreboot-gerrit] Change in coreboot[master]: cbfs: Simplify load/map API names, remove type arguments

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39304 )

Change subject: cbfs: Simplify load/map API names, remove type arguments
......................................................................

Patch Set 18:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39304/3/src/lib/cbfs.c 
File src/lib/cbfs.c:

https://review.coreboot.org/c/coreboot/+/39304/3/src/lib/cbfs.c@209 
PS3, Line 209: cbfs_load
> since we're here, I wonder if we can add a new API for loading blobs with unlimited buffer size, e. […]

Hmmm... but where does that allocator come from? I don't think we'd want to have every platform implement its own memory allocator somewhere. It's more efficient to just use a single allocator for everything, and currently we already have the CBFS_CACHE allocator so I think we should rather expand on that.

I think it would be reasonable to expand cbfs_map() so that it will transparently allocate space for the decompressed file and decompress it. The x86 boards currently have no concept of CBFS_CACHE so we would have to add it there for that to work, but that could be done. I don't really have time to work in that direction right now, but am happy to review patches if you want to.