Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Angel Pons, Meera Ravindranath.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63299 )
Change subject: soc/intel/alderlake: Update CPU IDs with correct steppings
......................................................................
Patch Set 2:
(1 comment)
File src/include/cpu/intel/cpu_ids.h:
https://review.coreboot.org/c/coreboot/+/63299/comment/9acd17e2_10bd50d2
PS2, Line 54: #define CPUID_ALDERLAKE_J0 0x906a0
: #define CPUID_ALDERLAKE_Q0 0x906a1
: #define CPUID_ALDERLAKE_K0 0x906a2
: #define CPUID_ALDERLAKE_R0 0x906a4
Out of curiosity, are these CPU IDs paired with a specific PCH type?
Yes sorrect. ADL-P is SoC hence PCH & CPU is packed in 1 single Die
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63299
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I722043c493b8c3de8965bcaa13f33c907d51f284
Gerrit-Change-Number: 63299
Gerrit-PatchSet: 2
Gerrit-Owner: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Comment-Date: Mon, 04 Apr 2022 11:25:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment