Attention is currently required from: Pablo Stebler, Paul Menzel, Iru Cai (vimacs). Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44750 )
Change subject: ec/hp/kbc1126: Wait a longer time after sending ......................................................................
Patch Set 8:
(2 comments)
Patchset:
PS8: I think a Kconfig is overkill here. The code calling the affected function doesn't look like it has a clue how to handle a timeout. Only if we know how to handle a timeout gracefully, it should be tight. If not and if the hardware (or other firmware component) is known to stall sometimes, it should be a trade-off between function and useability: Not too short of course, but not too long either so it wouldn't be noticed. However, if hardware (or the other firmware component) is know to always finish and we lose something by timing out early, the timeout should be high, really high. Even if we set it to 10s it wouldn't matter if it only takes >100ms once in a decade.
File src/ec/hp/kbc1126/Kconfig:
https://review.coreboot.org/c/coreboot/+/44750/comment/8045367e_70349512 PS8, Line 14: int "Maximum waiting time in ms after sending a command to the EC" Why does this need a prompt? Generally, those encourage downstream solutions, e.g. somebody writes a guide ("Set his to ...") instead of fixing coreboot.