[coreboot-gerrit] Change in coreboot[master]: mb/intel/adlrvp: Enable UFS for ADL-N RVP

[Meera Ravindranath (Code Review)]

Attention is currently required from: Subrata Banik, Wonkyu Kim, Rizwan Qureshi, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, Gwendal Grignou.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62662 )

Change subject: mb/intel/adlrvp: Enable UFS for ADL-N RVP
......................................................................

Patch Set 4:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/62662/comment/f12d97cb_5975b81d 
PS4, Line 10: also needs to be enabled. Hence, enable ISH as well.
> How about: […]

Ack

File src/mainboard/intel/adlrvp/devicetree_n.cb:

https://review.coreboot.org/c/coreboot/+/62662/comment/7b2a7707_79b963bf 
PS3, Line 283: on
> See the code in pcie_rp.c, the `struct pcie_rp_group` arrays in particular. […]

This is right, but I think Subrata was hinting at why the same logic doesn't apply for PCI devices too. 
@Subrata - There is no remapping logic in case of PCI devices in fsp unlike pcie and tbt RPs. Also, CB is not disabling the device 12.7 even if 12.0 is not enabled.
We are able to enumerate UFS in Depthcharge CLI even without 12.0 enabled.

But we see, the kernel fails enumerate 12.7 after this and enumerates only if the parent device 12.0 is enabled. Trying to check on this internally with the kernel folks and will get back.