Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34431 )
Change subject: mb/google/hatch: expose get_board_sku() as global
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34431/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34431/2/src/mainboard/google/hatch/...
PS2, Line 17: #include <baseboard/variants.h>
nit: this should go before boardid.h to keep the files in alphabetical order.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34431
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I217e13acd337034554ff055e8bf5011558d1f8bf
Gerrit-Change-Number: 34431
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jul 2019 05:03:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment