Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44455 )
Change subject: mb/google/volteer/halvor: Skip fw_config override on Halvor. ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review+1
@Googler, this project is for demo only. We don't want to compromise the real project. So we don't want add more fw_config or override function on this.
FW_CONFIG is already a config option. we probably just need to disable it on variants where it is not required.
volteer and volteer2 (the actual boards) need it but there are several variants that do not because they only have a single pre-determined config for audio, usb, etc.
do you plan to have multiple audio/sd/usb configs on halvor that would need runtime selection using fw_config?
We only have one config but it not in the current setting. Not worth to add one config for this project though. So you mean we disable FW_CONFIG then move all the setting in variant? Will this impact the OS config of audio?
if we disable FW_CONFIG for a particular variant, then that variant's gpio.c needs to have the expected GPIO settings (pretty easy). also, the device tree for that variant must not have any probe statements that use FW_CONFIG - that's already (mostly?) the case. the OS will get the same ACPI tables as before, they just won't depend on having FW_CONFIG in CBI defined correctly.