Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35266 )
Change subject: drivers/intel/fsp2_0: Use generic defines for early storage
......................................................................
Patch Set 1:
Patch Set 1:
Marshall, I am trying to get a decision between CB:35165 CB:35233 promptly so we know which one to rebase on the next time around.
I need to run to a meeting, but will look at these when I get back. I considered putting some space into car.ld to positively allocate it, then modify fsp2_0 to use that instead. I wasn't 100% confident that I wouldn't break Intel systems, in the process, though.
BTW, I really disliked this particular PS and I assumed it would be required to change due to whatever changes come before it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35266
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9d102c3c1110bbb54ce788ec432da1a27e2f61f
Gerrit-Change-Number: 35266
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 05 Sep 2019 19:19:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment