Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47411 )
Change subject: soc/intel/common: Adapt XHCI elog driver for reuse ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47411/5/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/xhci.h:
https://review.coreboot.org/c/coreboot/+/47411/5/src/soc/intel/common/block/... PS5, Line 36: and a usb_info : * struct.
Leftover comment? Or were you intending to add usb_info pointer to the above structure as well?
leftover for now.
https://review.coreboot.org/c/coreboot/+/47411/5/src/soc/intel/common/block/... File src/soc/intel/common/block/xhci/elog.c:
https://review.coreboot.org/c/coreboot/+/47411/5/src/soc/intel/common/block/... PS5, Line 111: elog_add_event_wake(wake_info[i].elog_wake_type_host, 0);
Isn't this being logged unconditionally now? […]
Oops yes, missed the check, but yeah forgot the s0ix resume clearing the wake status bit. Agreed, it would be nice to get the host controller before the port.