Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35277 )
Change subject: soc/intel/{common,skl,icl,cnl}: Move some bootblock code to common location
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35277/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35277/3//COMMIT_MSG@7
PS3, Line 7: skl,icl,cnl
OTOH i see https://review.coreboot. […]
I would like to see why APL/GLK is different and what are the factors that make it a bad fit for this model in case it cannot be done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35277
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7c563023c4b1ff4f42734f18b923d13afef4770
Gerrit-Change-Number: 35277
Gerrit-PatchSet: 3
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Sep 2019 17:15:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment