Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45001 )
Change subject: soc/intel/skylake: Rename PcieRpAspm devicetree config ......................................................................
Patch Set 3:
(1 comment)
Btw. there is some work going on to have a "chipset devicetree" that can declare devices and provide defaults. In theory, we could then have non-zero defaults and wouldn't need these off- by-one tricks anymore.
https://review.coreboot.org/c/coreboot/+/45001/3/src/soc/intel/skylake/chip.... File src/soc/intel/skylake/chip.h:
https://review.coreboot.org/c/coreboot/+/45001/3/src/soc/intel/skylake/chip.... PS3, Line 265: } pcierp_aspm[CONFIG_MAX_ROOT_PORTS];
Would PcieRp_Aspem better match other element names?
The idea is to differ so it doesn't look like the plain UPD. Also, CamelCase is usually not considered an option in coreboot.