Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35632 )
Change subject: device: add commentary to dev_find_slot() ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35632/1/src/device/device_const.c File src/device/device_const.c:
https://review.coreboot.org/c/coreboot/+/35632/1/src/device/device_const.c@2... PS1, Line 236: DEVTREE_CONST struct device *pcidev_path_on_root_debug(pci_devfn_t devfn, const char *func)
Can't we provide a variant that supplies bus number? Go through dev_root->link_list to find thos […]
Done
https://review.coreboot.org/c/coreboot/+/35632/1/src/include/device/device.h File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/35632/1/src/include/device/device.h... PS1, Line 310: DEVTREE_CONST struct device *pcidev_path_on_root_debug(pci_devfn_t devfn, const char *func);
Maybe latter should move up if we intent to have it around after dev_find_slot() is gone?
Done