build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37010 )
Change subject: sb/intel/common/smihandler: Use a common IO TRAP handler ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37010/2/src/southbridge/intel/commo... File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/c/coreboot/+/37010/2/src/southbridge/intel/commo... PS2, Line 470: for (i=16; i<20; i++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/2/src/southbridge/intel/commo... PS2, Line 470: for (i=16; i<20; i++) { spaces required around that '<' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/2/src/southbridge/intel/commo... PS2, Line 499: for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37010/2/src/southbridge/intel/commo... PS2, Line 499: for (i=0; i < 4; i++) if (IOTRAP(i)) printk(BIOS_DEBUG, " TRAP = %d\n", i); trailing statements should be on next line