Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45405 )
Change subject: console: Override uart base address
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45405/2/src/drivers/uart/uart8250io...
File src/drivers/uart/uart8250io.c:
https://review.coreboot.org/c/coreboot/+/45405/2/src/drivers/uart/uart8250io...
PS2, Line 78: static const unsigned int bases[] = { 0x3f8, 0x2f8, 0x3e8, 0x2e8 };
I was trying to understand how it changes to get to the best support. […]
I had an insane idea not too long ago: the `dynconfig()` macro
When there's no `dynconfig backend` (e.g. CMOS, VPD) to change options after building, this would be equivalent to the `CONFIG()` macro, and evaluate to a constant expression. However, if some `dynconfig backend` is enabled, then it would become a function call, which would retrieve the value through that backend. This would allow reusing the same Kconfig symbol names in the dynconfig backends (with some prefix to differentiate them from regular Kconfig symbols).
I didn't think about implementing this though, which is why I say it's an insane idea.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45405
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2079bd1e5ffa209553383b6aafe3b8724849ba2a
Gerrit-Change-Number: 45405
Gerrit-PatchSet: 3
Gerrit-Owner: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Sep 2020 19:06:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-MessageType: comment