17 Jan
2022
17 Jan
'22
3:45 p.m.
Attention is currently required from: Keith Hui. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41459 )
Change subject: mb/asus/p2b: list all unused Super I/O resources ......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/asus/p2b/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41459/comment/0b8e4d58_4a4ea86b PS8, Line 38: io 0x60 = 0 : io 0x62 = 0
Does the code treat the 0 specially? If not this is conflicting 2x port 0.
I think it's just to silence the warnings about "resource not set". If 0 is treated specially, it's most likely done by the hardware.
--
To view, visit https://review.coreboot.org/c/coreboot/+/41459
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28e37c3a58f3a6b5a613733f26ac18d6a7b3be2e
Gerrit-Change-Number: 41459
Gerrit-PatchSet: 8
Gerrit-Owner: Keith Hui buurin@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Keith Hui buurin@gmail.com
Gerrit-Comment-Date: Mon, 17 Jan 2022 15:45:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment