26 Mar
2019
26 Mar
'19
7:58 a.m.
Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32031 )
Change subject: chromeos: update old boards to use lb_add_gpios notation ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32031/5/src/mainboard/google/butterfly/chrom... File src/mainboard/google/butterfly/chromeos.c:
https://review.coreboot.org/#/c/32031/5/src/mainboard/google/butterfly/chrom... PS5, Line 55: - Suggestion for later: Add an enum for this value like GPIO_PSEUDO
--
To view, visit https://review.coreboot.org/c/coreboot/+/32031
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90795f32be5de881c94519933f36127098c184df
Gerrit-Change-Number: 32031
Gerrit-PatchSet: 5
Gerrit-Owner: Joel Kitching kitching@google.com
Gerrit-Reviewer: Joel Kitching kitching@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Simon Glass sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Mar 2019 14:58:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment