[coreboot-gerrit] Change in coreboot[master]: nb/intel/i945: Programm CxODT value for each channel

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18548 )

Change subject: nb/intel/i945: Programm CxODT value for each channel
......................................................................

Patch Set 26:

(2 comments)

https://review.coreboot.org/c/coreboot/+/18548/26//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/18548/26//COMMIT_MSG@10 
PS26, Line 10:
> Done

The commit message should be more elaborate.

https://review.coreboot.org/c/coreboot/+/18548/26/src/northbridge/intel/i945... 
File src/northbridge/intel/i945/raminit.c:

https://review.coreboot.org/c/coreboot/+/18548/26/src/northbridge/intel/i945... 
PS26, Line 2445: 	if (!(sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED &&
> From Nico's comment in PS22: It can be written even clearer by pulling the outer ! in: […]

Could be a clean-up patch before this one.