mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35506 )
Change subject: trogdor: support mbn_version 6 with python build scripts
......................................................................
Patch Set 36:
(1 comment)
Push later today addresses this last item and patch should be ready for review and merge.
https://review.coreboot.org/c/coreboot/+/35506/36/util/qualcomm/createxbl.py
File util/qualcomm/createxbl.py:
https://review.coreboot.org/c/coreboot/+/35506/36/util/qualcomm/createxbl.py...
PS36, Line 269: secure_type = image_header_secflag, header_version = header_version )
You said 'Done' here but you didn't actually put it on a new line.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35506
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I020d1e4d4f5c948948e1b39dd18af1d0e860c279
Gerrit-Change-Number: 35506
Gerrit-PatchSet: 36
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Doug Anderson
dianders@chromium.org
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rishabh Sharma
rishabh435@gmail.com
Gerrit-CC: ashk@codeaurora.org
Gerrit-Comment-Date: Fri, 07 Feb 2020 18:10:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment