Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39390 )
Change subject: cbfstool: Add vboot callback function vb2ex_printf()
......................................................................
Patch Set 3: Code-Review-1
Actually, I think the real problem here is different. vboot already solves this problem by containing stubs for its own callbacks when built for non-firmware use (including this one). The real problem is that cbfstool doesn't actually build the vboot library, it just cherry-picks a few random files and hopes that these files will continue to work standalone without any dependencies. That's pretty brittle and I think we would be better served by changing Makefiles so that we always build a HOSTCC version of the vboot library when building any host utilities and then link against that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39390
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc826896d895f53d69ea559a88f75672c2ec3146
Gerrit-Change-Number: 39390
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Mar 2020 20:53:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment