Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42916 )
Change subject: supermicro/x11-lga1151/gpio: 1/5 Decode raw register values ......................................................................
Patch Set 6:
(1 comment)
Thanks for the review
https://review.coreboot.org/c/coreboot/+/42916/6/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42916/6/src/mainboard/supermicro/x1... PS6, Line 580: PWROK
I'm not sure about the reset values here. […]
No, I decided to set 0, since 3h = Reserved. It seems to me that it is better not to use the reserved value here. I would like to know your opinion about this.
If you took into account remapping in gpio.h, then I will abandon the last patch (CB:42919).
I will make changes to intel2m to cancel remapping reset sources if we convert the gpio.h file.