Attention is currently required from: Jérémy Compostella, Nicholas Chin, Subrata Banik.
Julius Werner has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85905?usp=email )
Change subject: drivers/option: Add CBFS file based option backend ......................................................................
Patch Set 13:
(1 comment)
Patchset:
PS4:
First, we are forcing all previous and future generations of chromeos devices to bind with USE_CBFS_FILE_OPTION_BACKEND.
I know but I don't think there's really a drawback to enabling this. This also allows controlling other things (e.g. coreboot loglevel) via options, and it's cleaner to have that enabled for all devices than to only have it work on a few with no clear reason for the difference.
Second, what about non-CrOS devices? They might also wish to use the USE_CBFS_FILE_OPTION_BACKEND feature. The current model of relying on HAVE_ would allow any SoC/Mainboard to select this feature as per their need.
Yes, but selecting this from the mainboard Kconfig is fundamentally the wrong way to go about it. Mainboard Kconfigs are only supposed to describe hardware, not decide policy. Whether this feature is enabled or not is clearly a policy decision and not a property of the hardware (same as enabling timestamps and those kinds of options). That means it should be decided by the user in menuconfig instead (in the ChromeOS case, that means our downstream ebuilds), and there's no good reason why some hardware should have different defaults than other here.