24 Aug
2020
24 Aug
'20
5:39 p.m.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44480 )
Change subject: mb/google/zork: Switch zork to use spd_tools ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44480/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44480/3/src/mainboard/google/zork/v... PS3, Line 3:
This Makefile is missing the "MEMORY_TYPE = ddr4" declaration. […]
Or does Zork not need to differentiate between DDR4 and other supported memory types?
--
To view, visit https://review.coreboot.org/c/coreboot/+/44480
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0553858f83d3d1e90cf35bece108768f004a29a5
Gerrit-Change-Number: 44480
Gerrit-PatchSet: 3
Gerrit-Owner: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Peers epeers@google.com
Gerrit-CC: Nick Vaccaro nvaccaro@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 24 Aug 2020 20:39:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro nvaccaro@google.com
Gerrit-MessageType: comment