[coreboot-gerrit] [M] Change in coreboot[master]: soc/amd/*: Hook up device_operations in chipset.cb

[Arthur Heymans (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67738 )

Change subject: soc/amd/*: Hook up device_operations in chipset.cb
......................................................................

Patch Set 3:

(3 comments)

File src/soc/amd/cezanne/chip.c:

https://review.coreboot.org/c/coreboot/+/67738/comment/50def1c5_1f810f11 
PS1, Line 63: 		if (!dev->enabled)
> sounds good to me

Done

https://review.coreboot.org/c/coreboot/+/67738/comment/4eb86718_4fdc213b 
PS1, Line 37: static
> i think that this static needs to be removed

Right. As it's a global variable it should also be renamed.

File src/soc/amd/cezanne/chipset.cb:

https://review.coreboot.org/c/coreboot/+/67738/comment/38aef6d4_d6f12149 
PS1, Line 3: ops
> Ohh I like it. When did this get added?

https://review.coreboot.org/c/coreboot/+/66483/5 recently :-)