4 Dec
2019
4 Dec
'19
10:42 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37432 )
Change subject: mmio: Add clrsetbitsXX() API in place of updateX() ......................................................................
Patch Set 3:
Any reason not to use inline functions? Currently, `addr` is always evaluated twice. It shouldn't matter in practice, just wondering.
No sorry, I just expanded on what was there already. Inline functions make this a little harder to write (you need either very fancy macro magic or a lot of copy&paste), but not opposed to changing it if you want to.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4f7b9fdbdf9e8c0174427b4288f79006d56978b
Gerrit-Change-Number: 37432
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Dec 2019 22:42:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment